[fofix-commits] [fofix/fofix] 54b8a4: Fix where selection menu would exit without giving...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/fofix/fofix
  Commit: 54b8a4480b2bc42f5f7ea38549268b843fc4e827
      https://github.com/fofix/fofix/commit/54b8a4480b2bc42f5f7ea38549268b843fc4e827
  Author: William R. Zwicky <wrzwicky at pobox.com>
  Date:   2017-10-10 (Tue, 10 Oct 2017)

  Changed paths:
    M fofix/game/SongChoosingScene.py

  Log Message:
  -----------
  Fix where selection menu would exit without giving access to library
root dir.


  Commit: 88c96db52ea88aa219c0c04f82aa72307fd489ae
      https://github.com/fofix/fofix/commit/88c96db52ea88aa219c0c04f82aa72307fd489ae
  Author: William R. Zwicky <wrzwicky at pobox.com>
  Date:   2017-10-10 (Tue, 10 Oct 2017)

  Changed paths:
    M fofix/core/GameEngine.py
    M fofix/core/Theme.py
    M fofix/game/MainMenu.py
    M fofix/game/guitarscene/instruments/Drum.py

  Log Message:
  -----------
  Fix misc bugs discovered while looking at #49.


  Commit: c329141487bcff58bbdb3d94798599f20eeabd6d
      https://github.com/fofix/fofix/commit/c329141487bcff58bbdb3d94798599f20eeabd6d
  Author: William R. Zwicky <wrzwicky at pobox.com>
  Date:   2017-10-10 (Tue, 10 Oct 2017)

  Changed paths:
    M fofix/game/guitarscene/instruments/Drum.py

  Log Message:
  -----------
  Fix crash on drawing "open" notes.


  Commit: fb4308af8efe6c076eb6ccff6284e432a7f5baf4
      https://github.com/fofix/fofix/commit/fb4308af8efe6c076eb6ccff6284e432a7f5baf4
  Author: William R. Zwicky <wrzwicky at pobox.com>
  Date:   2017-10-10 (Tue, 10 Oct 2017)

  Changed paths:
    M fofix/core/GameEngine.py

  Log Message:
  -----------
  Improve logging when CustomTheme.py has problems.


  Commit: 0e5cc7419c063fe1e01007b2e53a2d9820f6d403
      https://github.com/fofix/fofix/commit/0e5cc7419c063fe1e01007b2e53a2d9820f6d403
  Author: William R. Zwicky <wrzwicky at pobox.com>
  Date:   2017-10-10 (Tue, 10 Oct 2017)

  Changed paths:
    M fofix/core/Theme.py

  Log Message:
  -----------
  Docs.


  Commit: 919e61f1f04dbe5b9bf49234d94a3bbb12342785
      https://github.com/fofix/fofix/commit/919e61f1f04dbe5b9bf49234d94a3bbb12342785
  Author: William R. Zwicky <wrzwicky at pobox.com>
  Date:   2017-10-10 (Tue, 10 Oct 2017)

  Changed paths:
    M fofix/game/guitarscene/instruments/Drum.py

  Log Message:
  -----------
  Fix #49 (rendering frets from a drum-specific fretbuttons.png)


  Commit: fc8a0ac7c003a69e0896fdf9f52dd68895e37016
      https://github.com/fofix/fofix/commit/fc8a0ac7c003a69e0896fdf9f52dd68895e37016
  Author: William R. Zwicky <wrzwicky at pobox.com>
  Date:   2017-10-10 (Tue, 10 Oct 2017)

  Changed paths:
    M fofix/core/GameEngine.py
    M fofix/game/guitarscene/instruments/Drum.py

  Log Message:
  -----------
  Style tweaks per Linkid's review.


  Commit: 281f3e73cf2d22fe238054e86dbadc4e563430d4
      https://github.com/fofix/fofix/commit/281f3e73cf2d22fe238054e86dbadc4e563430d4
  Author: William R. Zwicky <wrzwicky at pobox.com>
  Date:   2017-10-15 (Sun, 15 Oct 2017)

  Changed paths:
    M fofix/core/GameEngine.py

  Log Message:
  -----------
  Tidied up theme init.

Log where the theme files are coming from; isolate theme startup in its
own function; rearrange code so Theme class is created before anything
starts trying to find individual files.


  Commit: 3ac6029558748b7a8c1e367783650fb087d2d6da
      https://github.com/fofix/fofix/commit/3ac6029558748b7a8c1e367783650fb087d2d6da
  Author: William R. Zwicky <wrzwicky at pobox.com>
  Date:   2017-10-15 (Sun, 15 Oct 2017)

  Changed paths:
    M fofix/core/GameEngine.py

  Log Message:
  -----------
  Add justification for change in previous commit (which stopped using
theme icon as app icon).


  Commit: 999a0661138269c332ef796052b8a50f2934049c
      https://github.com/fofix/fofix/commit/999a0661138269c332ef796052b8a50f2934049c
  Author: William R. Zwicky <wrzwicky at pobox.com>
  Date:   2017-10-16 (Mon, 16 Oct 2017)

  Changed paths:
    M fofix/core/GameEngine.py
    M fofix/game/guitarscene/instruments/Drum.py

  Log Message:
  -----------
  Style tweaks per Linkid's review.


  Commit: 58b7d18374a8522770877bacd7952ef4d07851a7
      https://github.com/fofix/fofix/commit/58b7d18374a8522770877bacd7952ef4d07851a7
  Author: William R. Zwicky <wrzwicky at pobox.com>
  Date:   2017-10-17 (Tue, 17 Oct 2017)

  Changed paths:
    M fofix/core/GameEngine.py

  Log Message:
  -----------
  Justification for prior change.

Code change is in commit 281f3e73cf2d22fe238054e86dbadc4e563430d4. 

Justification:
Note that in the past, we used the theme icon if present. This is wrong
IMO; the window icon should match the thing that the user clicks in
their OS to start FoFiX.


  Commit: ddfb8b2dc3f027baa0c1e7a63b134444a3a2c2cb
      https://github.com/fofix/fofix/commit/ddfb8b2dc3f027baa0c1e7a63b134444a3a2c2cb
  Author: William R. Zwicky <wrzwicky at pobox.com>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M fofix/core/GameEngine.py

  Log Message:
  -----------
  Fix exception logging, missing variable, and leaky global.

Global vars at the top were leaking into the rest of the file; and this
hid an error with an undefined var.


  Commit: bc69033c6780966c58385fdabcf49f29d9d5f9e7
      https://github.com/fofix/fofix/commit/bc69033c6780966c58385fdabcf49f29d9d5f9e7
  Author: François Magimel <francois.magimel at alumni.enseeiht.fr>
  Date:   2017-11-01 (Wed, 01 Nov 2017)

  Changed paths:
    M fofix/core/GameEngine.py
    M fofix/core/Theme.py
    M fofix/game/MainMenu.py
    M fofix/game/SongChoosingScene.py
    M fofix/game/guitarscene/instruments/Drum.py

  Log Message:
  -----------
  Merge pull request #96 from wrzwicky/wrz_issue_49

Fix #49 and related bugs


Compare: https://github.com/fofix/fofix/compare/9d1cd920e0d5...bc69033c6780